chore(Go): update makefile and add extern for item encryptor in test vector#1862
Merged
rishav-karanjit merged 2 commits intoGolang/reviewedfrom May 6, 2025
Merged
chore(Go): update makefile and add extern for item encryptor in test vector#1862rishav-karanjit merged 2 commits intoGolang/reviewedfrom
rishav-karanjit merged 2 commits intoGolang/reviewedfrom
Conversation
rishav-karanjit
changed the title
rishav-karanjit
commented
May 5, 2025
| @@ -1,24 +1,25 @@ | |||
| # This workflow prevents TODOs in code | |||
| name: Check TODOs in code | |||
| # TODO: Uncomment this | |||
Member
Author
There was a problem hiding this comment.
As I was going to work on a different project (HV-2) and had to keep track of things remaining, I had added lots of TODO. This CI is not going to pass which is expected. So, commenting it now to make CI healthy.
josecorella
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
New updates after merging from main
Note: This PR lands into Golang/reviewed NOT main. The plan is to land it in main when everything is ready.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.